Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues in forum post preview for Telegram #12

Open
lassik opened this issue May 30, 2018 · 0 comments
Open

Issues in forum post preview for Telegram #12

lassik opened this issue May 30, 2018 · 0 comments
Labels
Milestone

Comments

@lassik
Copy link
Owner

lassik commented May 30, 2018

BBCode and [quote]s should be removed from Telegram previews of forum posts:

@jan-2017:

But there are no notification lines displayed in the Messanger if, for example, a quote is too long. The message after the quote will probably not be shown. The user wants to read the message and not the quote content. My suggestion would be to shorten the citation length and to show only a certain number of the beginning and end of the quote.Then there is more space for the actual message.

@lassik:

I agree. I tried to remove the bbcode (the [quote] and other such stuff) to leave only the plain text. I used https://wiki.phpbb.com/Function.strip_bbcode but could not get it to work easily - it removed all of the message text, leaving an empty message :) If you know how to do it (without writing our own bbcode parser or using regexps) please let me know.

The notifications about quoted messages definitely look weird right now and it would be great to have them fixed.

Some other problems:

  • Put usernames in bold so they are more prominent.
  • Maybe should use post title instead of topic title in notification messages. Usually doesn't matter, but can be confusing to use the topic title if it's very different from the post title.
  • Partial HTML tags may mess up the preview (missing closing tag? preview cut off in the middle of an opening tag?). Investigate.
  • Why do HTML tags end up in the preview in the first place? They shouldn't. Investigate.
  • Partial links (URLs) should never be displayed at the end of a preview (since links are clickable in telegram). Either the full link or no link at all.
@lassik lassik added the bug label May 30, 2018
@lassik lassik added this to the 0.7.0 milestone May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant