Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

Correct undefined constants warning #11

Closed
lat9 opened this issue Sep 21, 2018 · 0 comments
Closed

Correct undefined constants warning #11

lat9 opened this issue Sep 21, 2018 · 0 comments
Labels
bug fix provided
Milestone
v1.7.3

Comments

@lat9
Copy link
Owner

lat9 commented Sep 21, 2018

Per PR #10 by @benharold
@lat9 lat9 added the bug label Sep 21, 2018
lat9 added a commit that referenced this issue Sep 21, 2018
@lat9
#11: Update version/readme
771b5af 
Update the shipping-module version and note the change in the readme.
lat9 added a commit that referenced this issue Jun 26, 2019
@lat9
#11: Correct undefined-constants warnings
34c9efc 
Includes some minor reformatting, but essentially check to see if the
method's enable setting is present and set before using additional (not
defined) configuration settings.
@lat9 lat9 added this to the v1.7.3 milestone Jun 26, 2019
lat9 added a commit that referenced this issue Jun 26, 2019
@lat9
#8, #11, #12: Various updates!
209b43f 
- Don't make use of the UPS/XML configuration constants if the method's
not installed (they'll throw PHP warnings).
- Restructure logging to reduce in-line checks required.
- Don't return a quote if UPS indicated that there was an error.
- Various other PHP-notice type corrections.
@lat9 lat9 closed this as completed Jun 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug fix provided
Projects
None yet
Milestone
v1.7.3
Development

No branches or pull requests
1 participant
@lat9