Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

\prop_put_if_new:Nnn vs \prop_put_if_not_in:Nnn #1511

Closed
muzimuzhi opened this issue Mar 20, 2024 · 2 comments · Fixed by #1525
Closed

\prop_put_if_new:Nnn vs \prop_put_if_not_in:Nnn #1511

muzimuzhi opened this issue Mar 20, 2024 · 2 comments · Fixed by #1525

Comments

@muzimuzhi
Copy link
Contributor

Would \prop_(g)put_if_not_in:Nnn be easier to understand than the current \prop_(g)put_if_new:Nnn?

We have \<type>_if_in:Nn(TF) and all other occurrences of "new" in l3kernel function names are verb-like: new, new_conditional, (g)clear_new, (g)zero_new.
@FrankMittelbach
Copy link
Member

My initial reaction would be yes, it seems easier to understand as I wouldn't perceive a "key" as an object and it also fits better with \prop_if_in:NnTF.

@josephwright
Copy link
Member

Make a PR?

muzimuzhi added a commit to muzimuzhi/latex3 that referenced this issue Mar 29, 2024
@muzimuzhi
Rename \prop_(g)put_if_new:Nn to \prop_(g)put_if_not_in:Nn
0b7fa90 
See latex3#1511.
@muzimuzhi muzimuzhi mentioned this issue Mar 29, 2024
Merged
josephwright pushed a commit that referenced this issue Mar 31, 2024
@muzimuzhi @josephwright
Rename \prop_(g)put_if_new:Nn to \prop_(g)put_if_not_in:Nn
a4f8450 
See #1511.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename \prop_(g)put_if_new:Nnn to \prop_(g)put_if_not_in:Nnn muzimuzhi/latex3
3 participants
@josephwright @FrankMittelbach @muzimuzhi