-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
luahbtex/harf mode vs. AAT font #155
Comments
I currently can't reproduce this because I don't have access to the font. Does something similar happen with any open font? |
@schlcht Have you verified that the shaper coretext_aat even exists? I thought that it was removed some time ago? |
@zauguin Do you have any suggestions for a free AAT font that I could use for testing? As for |
I can't experiment with coretext anyway, but that sounds weird. First, slightly off-topic: Have you tried if your AAT font works without specifying any To get back to the actual issue, what do you get with
and
? |
|
Yes, loading HoeflerText (or any other font) without specifying any shaper works fine. Loading LatinModernRoman only works with I did find a font that works with |
I just pushed 4d44dcd to @u-fischer How do we want to handle this? We could raise an error or just print a warning and don't shape the affected text. (Currently the warning option is implemented) |
HarfBuzz will error if the specified shaper does not exist or not supported by the font. What is passed to HarfBuzz a list of shapers to be tried one by one (overriding the default order), and if the font does not support a shaper it will be skipped and if no shapers are left an error will happen and no output is given. The code could work around this by allowing appending |
( |
I used another approach on purpose because I tried to avoid exactly that: I do not want a silent fallback to because I think that would give the impression that the specified shaper worked. So the current approach is to do the fallback manually and therefore allowing us to intercept it and inform the user what is going on. |
That is your call. In hindsight, the shaper option was not the best idea. There are in reality two HarfBuzz shapers now, HarfBuzz default shpers list gives priority to The other shapers ( |
@u-fischer How do we want to handle this? We could raise an error or just print a warning and don't shape the affected text. (Currently the warning option is implemented) Imho if text gets lost an error is the right thing to do. |
The new version no longer loses text, it just doesn't shape it and passes it on unchanged. But I'm also convinced by now that this should be an error. |
The following, compiled with luahbtex on a Mac, results in a completely blank pdf.
There is no error message, and the meaning of
\1
is shown as expected, however neither is the font embedded in the pdf nor are the glyphs contained in the shipped out box, which are therefore even underfull (see attached test.log).This happens with the shapers
graphite2
andcoretext_aat
, but not withot
or if no shaper is specified. There also isn't any problem with luatex.The text was updated successfully, but these errors were encountered: