Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broad HQ residual cleanup #1389

Open
weinbe2 opened this issue Jul 3, 2023 · 0 comments
Open

Broad HQ residual cleanup #1389

weinbe2 opened this issue Jul 3, 2023 · 0 comments
Assignees
@weinbe2
Labels
clean-up

Comments

@weinbe2
Copy link
Contributor

weinbe2 commented Jul 3, 2023

As a follow up to #1387 (which is meant to just be a hotfix), I want to do more clean-up surrounding HQ residual solves:

  • Split CG with a HQ tolerance into a separate solver class, since the HQ residual is only used with CG anywho
  • Remove support for the HQ residual from the ReliableUpdates class since the HQ solve just keeps things easy
  • More broadly, remove the HQ arguments from the convergence and convergenceL2 functions in the solvers class, since the HQ residual is the exception, not the norm, and doesn't need to live everywhere.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weinbe2 weinbe2

Labels
clean-up
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@weinbe2