Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: matching Perlin noise implementations in Solidity and AssemblyScript #145

Merged
merged 19 commits into from
Sep 14, 2022

Conversation

alvrs
Copy link
Member

@alvrs alvrs commented Sep 14, 2022

  • add Perlin noise implementations in Solidity and AssemblyScript.
  • add tests to make sure Solidity and AssemblyScript implementations compute the same result and it's proper Perlin noise.

@alvrs alvrs marked this pull request as ready for review September 14, 2022 09:10
@alvrs alvrs requested a review from ludns September 14, 2022 09:10
@alvrs alvrs changed the title feat: Perlin noise implementations in Solidity and AssemblyScript feat: matching Perlin noise implementations in Solidity and AssemblyScript Sep 14, 2022
Copy link
Member

@ludns ludns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incredible code and attention to details. Mr Perlin would be happy.

@alvrs alvrs merged commit 29094c4 into main Sep 14, 2022
github-actions bot pushed a commit that referenced this pull request Sep 14, 2022
…ty and AssemblyScript (#145)

* test(noise): add basic hardhat test setup

* feat: add wasm simplex noise

* chore: wip assemblyscript setup

* feat: add assemblyscript port of Perlin.sol

* chore: change folder structure

* chore: add createPerlinWasm for initializing wasm functions

* docs(noise): add typedoc for createPerlinWasm

* feat(noise): add smoothStep interpolation to solidity and wasm perlin implementation

* feat(noise): wip add own perlin implementation, support for negative values and arbitrary precision

* test(noise): add tests for new solidity perlin implementation

* feat(noise): add AssemblyScript implementation of perlin3

* chore: cleanup

* chore: wip

* build(noise): turn noise package into es module, fix hardhat tests

* chore: gas golf Perlin.sol

* fix: self-review

* test(noise): skip hardhat test until ts/esm support PR is merged into hardhat

* chore: remove unused hardhat script

* chore: add license
@alvrs alvrs deleted the alvrs/op branch January 5, 2023 11:23
LPSCRYPT pushed a commit to LPSCRYPT/esp that referenced this pull request Jan 23, 2023
…cript (latticexyz#145)

* test(noise): add basic hardhat test setup

* feat: add wasm simplex noise

* chore: wip assemblyscript setup

* feat: add assemblyscript port of Perlin.sol

* chore: change folder structure

* chore: add createPerlinWasm for initializing wasm functions

* docs(noise): add typedoc for createPerlinWasm

* feat(noise): add smoothStep interpolation to solidity and wasm perlin implementation

* feat(noise): wip add own perlin implementation, support for negative values and arbitrary precision

* test(noise): add tests for new solidity perlin implementation

* feat(noise): add AssemblyScript implementation of perlin3

* chore: cleanup

* chore: wip

* build(noise): turn noise package into es module, fix hardhat tests

* chore: gas golf Perlin.sol

* fix: self-review

* test(noise): skip hardhat test until ts/esm support PR is merged into hardhat

* chore: remove unused hardhat script

* chore: add license
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants