-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: matching Perlin noise implementations in Solidity and AssemblyScript #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
alvrs
commented
Sep 14, 2022
•
edited
Loading
edited
- add Perlin noise implementations in Solidity and AssemblyScript.
- add tests to make sure Solidity and AssemblyScript implementations compute the same result and it's proper Perlin noise.
…values and arbitrary precision
alvrs
changed the title
feat: Perlin noise implementations in Solidity and AssemblyScript
feat: matching Perlin noise implementations in Solidity and AssemblyScript
Sep 14, 2022
ludns
approved these changes
Sep 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
incredible code and attention to details. Mr Perlin would be happy.
github-actions bot
pushed a commit
that referenced
this pull request
Sep 14, 2022
…ty and AssemblyScript (#145) * test(noise): add basic hardhat test setup * feat: add wasm simplex noise * chore: wip assemblyscript setup * feat: add assemblyscript port of Perlin.sol * chore: change folder structure * chore: add createPerlinWasm for initializing wasm functions * docs(noise): add typedoc for createPerlinWasm * feat(noise): add smoothStep interpolation to solidity and wasm perlin implementation * feat(noise): wip add own perlin implementation, support for negative values and arbitrary precision * test(noise): add tests for new solidity perlin implementation * feat(noise): add AssemblyScript implementation of perlin3 * chore: cleanup * chore: wip * build(noise): turn noise package into es module, fix hardhat tests * chore: gas golf Perlin.sol * fix: self-review * test(noise): skip hardhat test until ts/esm support PR is merged into hardhat * chore: remove unused hardhat script * chore: add license
LPSCRYPT
pushed a commit
to LPSCRYPT/esp
that referenced
this pull request
Jan 23, 2023
…cript (latticexyz#145) * test(noise): add basic hardhat test setup * feat: add wasm simplex noise * chore: wip assemblyscript setup * feat: add assemblyscript port of Perlin.sol * chore: change folder structure * chore: add createPerlinWasm for initializing wasm functions * docs(noise): add typedoc for createPerlinWasm * feat(noise): add smoothStep interpolation to solidity and wasm perlin implementation * feat(noise): wip add own perlin implementation, support for negative values and arbitrary precision * test(noise): add tests for new solidity perlin implementation * feat(noise): add AssemblyScript implementation of perlin3 * chore: cleanup * chore: wip * build(noise): turn noise package into es module, fix hardhat tests * chore: gas golf Perlin.sol * fix: self-review * test(noise): skip hardhat test until ts/esm support PR is merged into hardhat * chore: remove unused hardhat script * chore: add license
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.