Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename waitForTransaction to waitForStateChange #3114

Closed
holic opened this issue Sep 1, 2024 · 1 comment
Closed

rename waitForTransaction to waitForStateChange #3114

holic opened this issue Sep 1, 2024 · 1 comment

Comments

@holic
Copy link
Member

holic commented Sep 1, 2024 •
edited
Loading

to better reflect its intent: waiting for the state change after a tx is submitted

can also add some docs for why this is important to do and not just waitForTransactionReceipt (which could lead to UI jank)
@holic
Copy link
Member Author

holic commented Sep 20, 2024

decided against this (see #3210) because txs won't always mutate state and I can't think of a better name to reflect "wait for storage adapter to have seen this transaction"

@holic holic closed this as completed Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
MUD
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@holic