Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use hardhat as node (better logs) and make hardhat compatible with forge #54

Merged
merged 8 commits into from
Jul 6, 2022
Merged

fix: use hardhat as node (better logs) and make hardhat compatible with forge #54

merged 8 commits into from
Jul 6, 2022

Conversation

alvrs
Copy link
Member

@alvrs alvrs commented Jul 6, 2022 •
edited
Loading

  • Anvil doesn't provide good support for logs (yet). Transactions fail without proper log and console.log doesn't work. This PR changes the local node to hardhat (which has much better support for logs)
  • While moving the node back to hardhat, we still want to use forge to deploy the contracts (much faster and we don't have to maintain two scripts for deployment and tests). Sadly hardhat and forge don't like each other, so this PR also adds a forked version of hardhat that adds support for the RPC calls made by forge when deploying contracts.

@alvrs alvrs changed the title Debugging anvil fix: use hardhat as node (better logs) and make hardhat compatible with forge Jul 6, 2022
@alvrs alvrs requested a review from ludns July 6, 2022 03:04
@alvrs alvrs marked this pull request as ready for review July 6, 2022 03:04
@ludns ludns merged commit 45a5981 into main Jul 6, 2022
@ludns ludns deleted the debugging-anvil branch July 6, 2022 03:22
davidkol pushed a commit that referenced this pull request Jul 7, 2022
@alvrs @Kooshaba @davidkol
fix: use hardhat as node (better logs) and make hardhat compatible wi…
88e3837 
…th forge (#54)

* fix: wip

* chore: wip

* fix: add hardhat fork compatible with foundry deploy

* feat: with playerJoinFacet and persona

* fix: remove sketchy stuff

* fix: reset hardhat gas fee after deploying contracts with forge

* fix: self-review

* fix: self-review

Co-authored-by: Andy Cernera <kooshaba@gmail.com>
LPSCRYPT pushed a commit to LPSCRYPT/esp that referenced this pull request Jan 23, 2023
@alvrs @Kooshaba
fix: use hardhat as node (better logs) and make hardhat compatible wi…
3768a11 
…th forge (latticexyz#54)

* fix: wip

* chore: wip

* fix: add hardhat fork compatible with foundry deploy

* feat: with playerJoinFacet and persona

* fix: remove sketchy stuff

* fix: reset hardhat gas fee after deploying contracts with forge

* fix: self-review

* fix: self-review

Co-authored-by: Andy Cernera <kooshaba@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludns ludns ludns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alvrs @ludns @Kooshaba