Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(world): give World contract access to root namespace #575

Merged
merged 1 commit into from
Apr 2, 2023

Conversation

alvrs
Copy link
Member

@alvrs alvrs commented Apr 2, 2023

  • The World didn't have access to the root namespace. This doesn't matter for situations where the World writes to its own storage, but it matters for root systems who want to call other root systems via the World. Since root systems are delegatecalled from the World, address(this) in the System is the world address. If these systems try to call a method on the World, it's considered an external call, so access control checks apply, and fail if the World doesn't have access to the root namespace.

@alvrs alvrs requested a review from holic as a code owner April 2, 2023 10:51
Copy link
Member

@ludns ludns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants