Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made compatible with Python 3.5 #105

Merged
merged 1 commit into from Jan 25, 2021
Merged

Made compatible with Python 3.5 #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .python-version
View file
Open in desktop
@@ -0,0 +1 @@
3.5.9
2 changes: 1 addition & 1 deletion launchable/commands/verify.py
View file
Open in desktop
Expand Up @@ -40,7 +40,7 @@ def compare_java_version(output: str) -> int:

def check_java_version(javacmd: str) -> int:
"""Check if the Java version meets what we need. returns >=0 if we meet the requirement"""
v = subprocess.run([javacmd,"-version"], check=True, capture_output=True, text=True)
v = subprocess.run([javacmd,"-version"], check=True, stderr=subprocess.PIPE, universal_newlines=True)
return compare_java_version(v.stderr)

@click.command(name="verify")
Expand Down