Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Update context filter class to match preferred coding style #364

Merged
merged 4 commits into from
Jan 24, 2024

Conversation

keelerm84
Copy link
Member

No description provided.

@keelerm84 keelerm84 requested a review from a team as a code owner January 24, 2024 14:43
Copy link

This pull request has been linked to Shortcut Story #228721: Anonymous attribute redaction for feature events.

@keelerm84
Copy link
Member Author

Feedback from #363 mentioned that this file wasn't following the newly established conventions. So I'm fixing that in a separate PR.

There is one method on the context filter class, emplace, which I didn't convert to PascalCase. I see that emplace is a more common method name in C++, so I thought you may want to keep that consistent. Happy to change it if not.

@cwaldren-ld
Copy link
Contributor

Let's have emplace use PascalCase as well.

Copy link
Contributor

@cwaldren-ld cwaldren-ld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(approved pending renaming -> Emplace)

@cwaldren-ld cwaldren-ld changed the title style: Update context filter class to match preferred coding style refactor: Update context filter class to match preferred coding style Jan 24, 2024
@keelerm84 keelerm84 merged commit 2ab4963 into main Jan 24, 2024
20 checks passed
@keelerm84 keelerm84 deleted the mk/sc-228721/format branch January 24, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants