feat: redact anonymous attributes within feature events #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #228721: Anonymous attribute redaction for feature events. |
keelerm84
commented
Jan 22, 2024
| * @param context The context to redact. | ||
| * @return JSON suitable for an analytics event. | ||
| */ | ||
| JsonValue filter_with_anonymous_redaction(Context const& context); |
There was a problem hiding this comment.
Wasn't sure what the casing convention was for this repo so don't hesitate to nitpick!
There was a problem hiding this comment.
This file was written before we really solidified the standard we were using, and so it has tricked you.
The filter function should be Filter and yours should be FilterWithAnonymousRedaction.
For the private function it would normally just be private, no name specialization. But yours needs name specialization for a conflict. So something like FilterInternal.
We did put an abbreviated style guide here: https://github.com/launchdarkly/cpp-sdks/blob/main/CONTRIBUTING.md
| * @param redactAnonymous Whether to redact all attributes from anonymous contexts. | ||
| * @return JSON suitable for an analytics event. | ||
| */ | ||
| JsonValue filter_(Context const& context, bool redactAnonymous); |
There was a problem hiding this comment.
Trailing _ the preference? Or something like internalFilter?
There was a problem hiding this comment.
Should be able to call it just filter, as an overload
keelerm84
force-pushed
the
feat/inline-contexts
branch
from
e9ff718
to
5207b77
Compare
keelerm84
force-pushed
the
mk/sc-228721/anonymous-attribute-redaction
branch
from
20f2a3c
to
1745a2c
Compare
keelerm84
force-pushed
the
mk/sc-228721/anonymous-attribute-redaction
branch
from
1745a2c
to
ee736d0
Compare
cwaldren-ld
reviewed
Jan 26, 2024
Co-authored-by: Casey Waldren <cwaldren@launchdarkly.com>
cwaldren-ld
reviewed
Jan 29, 2024
| .AddPrivateAttribute("/object/test") | ||
| .Kind("org", "org-key") | ||
| .Set("isCat", true) | ||
| .Set("email", "cat@cat.cat") |
There was a problem hiding this comment.
TIL that cat is a real TLD (Catalan): https://www.gandi.net/en-US/domain/tld/cat
cwaldren-ld
approved these changes
Jan 29, 2024
keelerm84
added a commit
that referenced
this pull request
Mar 13, 2024
Co-authored-by: Casey Waldren <cwaldren@launchdarkly.com>
keelerm84
added a commit
that referenced
this pull request
Mar 15, 2024
Co-authored-by: Casey Waldren <cwaldren@launchdarkly.com>
Merged
cwaldren-ld
added a commit
that referenced
this pull request
Mar 19, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>launchdarkly-cpp-client: 3.4.1</summary> ## [3.4.1](launchdarkly-cpp-client-v3.4.0...launchdarkly-cpp-client-v3.4.1) (2024-03-18) ### Dependencies * The following workspace dependencies were updated * dependencies * launchdarkly-cpp-internal bumped from 0.5.4 to 0.6.0 </details> <details><summary>launchdarkly-cpp-internal: 0.6.0</summary> ## [0.6.0](launchdarkly-cpp-internal-v0.5.4...launchdarkly-cpp-internal-v0.6.0) (2024-03-18) ### Features * always inline contexts for feature events ([#362](#362)) ([bc77e89](bc77e89)) * redact anonymous attributes within feature events ([#363](#363)) ([85fe237](85fe237)) ### Bug Fixes * handle omitted evaluation result value when deserializing client-side JSON payload ([#368](#368)) ([334ea51](334ea51)) </details> <details><summary>launchdarkly-cpp-server: 3.3.3</summary> ## [3.3.3](launchdarkly-cpp-server-v3.3.2...launchdarkly-cpp-server-v3.3.3) (2024-03-18) ### Dependencies * The following workspace dependencies were updated * dependencies * launchdarkly-cpp-internal bumped from 0.5.4 to 0.6.0 </details> <details><summary>launchdarkly-cpp-server-redis-source: 2.1.3</summary> ## [2.1.3](launchdarkly-cpp-server-redis-source-v2.1.2...launchdarkly-cpp-server-redis-source-v2.1.3) (2024-03-18) ### Dependencies * The following workspace dependencies were updated * dependencies * launchdarkly-cpp-server bumped from 3.3.2 to 3.3.3 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Casey Waldren <cwaldren@launchdarkly.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.