prepare 5.1.0 release #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
better config validation
remove unused Rollup plugins, update dependencies
(1) use new test helpers + misc test cleanup
(2) clean up stream testing logic
…-types clearer way to model the config option defaults/types
…pper # Conflicts: # src/EventProcessor.js # src/EventSender.js # src/Stream.js # src/__tests__/EventSender-test.js # src/configuration.js # typings.d.ts
# Conflicts: # src/EventSender.js
…-wrapper # Conflicts: # src/EventProcessor.js # src/EventSender.js # src/__tests__/EventSender-test.js
…dk-for-u2c-release [sc-178313] Replace instances of user for release
[sc-178324] Merge u2c changes for major release
This pull request was auto generated by the Launchdarkly Github Standards automation platform. * Add default CODEOWNERS file
The `httpFallbackPing` has been broken for many years because it's incorrectly appending the fallback image url to the events url. Upon investigation the relevant parts of the sdk which deals with this fallback mechanism are outdated and no longer valid. They were used at a time when some browsers don't support XMLHttpRequest. Now we can remove usePost and consequently httpFallbackPing . I think this is safe because according to [this](https://caniuse.com/?search=XMLHttpRequest) all the major browsers we support support XMLHttpRequest. IE10 & 11 don't support JSON as response type but: 1. We're not processing the response body. we send content-type as json, and then we process the response status and header. 2. IE is no longer supported by Microsoft as of Feb 2023, so we're following suit. See slack [thread](https://launchdarkly.slack.com/archives/CA3KD877U/p1689592583516489).
We got feedback from a customer that they were confused by the "goals" language in our SDK docs, which we now call "metrics." This clarifies that goals = metrics and A/B testing = Experimentation. Story details: https://app.shortcut.com/launchdarkly/story/213100
This pins the dev typings of node to allow the typescript check to pass. This is temporary to keep this code working until it is replaced by a TypeScript implementation.
kinyoklion
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[5.1.0] - 2024-03-19
Changed:
Fixed:
Removed: