Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add confirmation to dangerous actions #5

Closed
AttilaBalla opened this issue May 14, 2019 · 6 comments
Closed

Add confirmation to dangerous actions #5

AttilaBalla opened this issue May 14, 2019 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@AttilaBalla
Copy link

AttilaBalla commented May 14, 2019

Hello,

We just switched to your admintool and I accidentally managed to wipe BPs twice now due to 2 really inconvenient behaviors.

The tool sometimes places the mouse cursor on the center of the screen, and it just so happens that the BP reset button is right there as well, so if for example I'm trying to teleport to a player and it doesn't work, when my mouse gets reset I end up wiping BPs instead.

Second major issue is that there is no confirmation message or warning dialog either, yet the BP reset and the inventory clear actions can cause serious issues if used by accident.

@LauraRozier
Copy link
Owner

1st issue : Not something I am able to fix, this is due to the slowness of the UI API. (Not a umod issue, a game issue.)

2nd issue : I could look into this, though I believe the user should be careful with admin panels and not accidentally click on buttons, always double check.

@AttilaBalla
Copy link
Author

Yeah I agree with that, however these 2 issues correlate, if the tool wouldn't move my mouse then it would be easier to avoid doing unintentional actions. Our previous tool didn't do this, so while i'm not familiar with how plugin development works, I'd say it's worth to investigate.

Also the "Main" screen does not really provide any useful information so I suggest showing the "online players" tab when opening the tool. That's another minor but inconvenient issue that I have with it.

Btw I really appreciate the quick response and I'm happy that this is a tool that's still being developed, so I'm only trying to provide constructive feedback.

Thanks a lot :)

@LauraRozier
Copy link
Owner

All fine. :)
Plugin UI development is hellish for more complex "Community UI". The end result is a JSON string to the client RPC. what I could do is have some more constant/readonly objects rather then regenerating them each time. Or use a transparent background panel to parent the actual UI and just destroy the actual UI on each page switch, that way the CursorEnabled will stay enabled.

Not sure what other tool you used in the past, though.
The main tab at the moment just houses the "Ban by ID" input, indeed. Didn't really know where else to stuff it.

@LauraRozier LauraRozier self-assigned this May 14, 2019
@LauraRozier LauraRozier added the enhancement New feature or request label May 14, 2019
@LauraRozier
Copy link
Owner

LauraRozier commented May 15, 2019

Could you perhaps try the most recent commit and tell me if this is better?
I sadly didn't get the chance to test it yet.

It doesn't include the confirms.

@AttilaBalla
Copy link
Author

Sure thing, what changes should we look out for?

@LauraRozier
Copy link
Owner

Mainly speed and the self-centering mouse cursor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants