Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Support "select all" in the note list #2403

Merged
merged 3 commits into from Feb 4, 2020

Conversation

miciasto
Copy link
Contributor

@miciasto miciasto commented Jan 29, 2020

Please consider this PR for enhancing the "select all" function in Joplin.

As mentioned in forum

Spec

  • When focus is in the note list, "select all" selects all notes.
  • When in the folder list, "select all" does nothing.
  • When in the tag list, "select all" does nothing.
  • The key combination "select all" is "Ctrl-A" or "Cmd-A"

select-all-new

For reference, the current behaviour is this:
select-all-current

Tests

  • Add unit test for new "NOTE_SELECT_ALL" handler in reducer

Manual tests:

Check 'select all' works:

  • in note list (selects all notes in note list)
  • in tag list (does nothing)
  • in folder list (does nothing)
  • in note text (still works and is unaffected)

Discussion

If the note list is short, and "select all" is actioned below the last note, the application menus are selected. I would like to stop this too, but don't know where to catch it. So leaving it as is for now.

@miciasto miciasto changed the title Desktop: Implement "select all" in the note list Desktop: Enable "select all" in the note list Jan 29, 2020
@miciasto miciasto changed the title Desktop: Enable "select all" in the note list Desktop: Support "select all" in the note list Jan 29, 2020
@tessus tessus added the desktop All desktop platforms label Jan 30, 2020
@laurent22
Copy link
Owner

I didn't test, but the code looks good and there are test units, so let's merge! Thanks for the quality pull request @mic704b!

@laurent22 laurent22 merged commit 5395d57 into laurent22:master Feb 4, 2020
@miciasto
Copy link
Contributor Author

miciasto commented Feb 5, 2020

Thank you @laurent22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop All desktop platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants