-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Desktop: Enhance notelist focus behaviour #2520
Conversation
Just need to fix the conflict and we can merge. (The "app" folder was removed so you will need to move your file one level down) |
I'm going to postpone this for now, until I get a chance to look at it. It works for note delete, but breaks new note behaviour. |
cbcac9b
to
450d73d
Compare
Fixed and ready for review. |
I'd like to merge this. Is there anything left to do? @laurent22 you already gave the ok to merge, but there were a few changes after your comment. Please advise. |
Looks good but I didn't test, however if you guys think it's ready to merge, please go ahead. |
Oh, yes, I forgot to add the |
This PR contains two enhancements to focus behaviour in the note list:
Focus following delete
Delete
key or context-menu)Up
orDown
key to select the next noteExpected: the next note is selected, the user can continue navigating with the keys
Actual: nothing, the note list does not respond to the navigation keys anymore
Focus when navigating "away" from multiple-note selection.
Up
orDown
key to select the next noteExpected: the next note is selected, and the previous notes are deselected
Actual: nothing, the note list does not respond to navigation keys anymore
This fix also fixes another issue discussed in forum as a side effect.