Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Desktop: Fix #5850: Focuses an editor after local search is closed #5919

Merged
merged 2 commits into from
Dec 28, 2021
Merged

Desktop: Fix #5850: Focuses an editor after local search is closed #5919

merged 2 commits into from
Dec 28, 2021

Conversation

ken1kob
Copy link
Contributor

@ken1kob ken1kob commented Dec 27, 2021 •
edited
Loading

This PR fixes issue #5850.

Implemented features:

  • When a local search is executed, the current highlighted search result is selected (with a cursor move).
  • After the local search bar is closed, Markdown Editor is focused.

@ken1kob ken1kob changed the title Desktop: Fix #5820: Focuses an editor after local search is closed Desktop: Fix #5850: Focuses an editor after local search is closed Dec 27, 2021
@ken1kob ken1kob mentioned this pull request Dec 27, 2021
Closed
@laurent22
Copy link
Owner

Thanks for the fix @ken1kob!

@laurent22 laurent22 merged commit b98e64c into laurent22:dev Dec 28, 2021
laurent22 added a commit that referenced this pull request Jan 19, 2022
@laurent22
Revert "Desktop: Fixes #5850: Editor loses cursor focus when Ctrl+F s…
c668bb0 
…earch is closed (#5919)"

This reverts commit b98e64c.

Ref: #6035
@CalebJohn CalebJohn mentioned this pull request Jan 19, 2022
Closed
@ken1kob ken1kob mentioned this pull request Jan 19, 2022
Closed
CalebJohn pushed a commit to CalebJohn/joplin that referenced this pull request Jan 20, 2022
@ken1kob @CalebJohn
Desktop: Fixes laurent22#5850: Editor loses cursor focus when Ctrl+F …
9331513 
…search is closed (laurent22#5919)
CalebJohn pushed a commit to CalebJohn/joplin that referenced this pull request Jan 20, 2022
@ken1kob @CalebJohn
Desktop: Fixes laurent22#5850: Editor loses cursor focus when Ctrl+F …
16cc791 
…search is closed (laurent22#5919)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ken1kob @laurent22