Desktop: Resolve #6254: <details> elements remain closed when exporting to PDF #7515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
laurent22
reviewed
Dec 22, 2022
gtlsgamr
commented
Dec 27, 2022
laurent22
reviewed
Dec 27, 2022
|
All good now, thanks! |
|
I shouldn't have merged since the code doesn't pass the linter. Next time please don't commit directly from GitHub because the precommit script doesn't run here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When exporting a note to pdf, any
<details>tags remain closed, which should not be expected behaviour since the data inside them will not be visible.This PR opens the tags before printing the pdf and closes them once it is done, thus solving #6254