Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron-builder maximum compression #8068

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Conversation

palerdot
Copy link
Contributor

@palerdot palerdot commented Apr 19, 2023

Related to #8028

dist/Joplin-2.11.1.dmg

Size is reduced roughly by 20MB
Before - 168MB
After - 149MB

CI builds are taking slightly longer (roughly ~2-4 minutes longer)

Windows:

Before - 22 minutes
After - 26 minutes

Linux:

Before - 14 minutes
After - 16 minutes

Mac:

Before - 28 minutes
After - 33 minutes

@palerdot palerdot force-pushed the electron-builder-compression branch from 7467669 to dab6115 Compare April 19, 2023 09:50
@laurent22
Copy link
Owner

laurent22 commented Apr 19, 2023

How does that compare to High compression?

How long to compress with max vs high?

@palerdot
Copy link
Contributor Author

How does that compare to High compression?

There is no high compression. Possible values are “store” | “normal” | “maximum” | “undefined” - https://www.electron.build/configuration/configuration.html. I have indicated the size difference between default (normal) and maximum compression in the PR description, which is
Before - 168MB
After - 149MB

How long to compress with max vs high?

In my local, it didn't make much of a difference (didn't time it). I think timing has to be compared in CI, which is currently failing for unknown reasons. I will retrigger the build.

@palerdot
Copy link
Contributor Author

CI builds are taking slightly longer (roughly ~2-4 minutes longer)

Windows:

Before - 22 minutes
After - 26 minutes

Linux:

Before - 14 minutes
After - 16 minutes

Mac:

Before - 28 minutes
After - 33 minutes

@laurent22
Copy link
Owner

Ok, good to go then, thanks

@laurent22 laurent22 marked this pull request as ready for review April 20, 2023 08:00
@laurent22 laurent22 merged commit 079b379 into dev Apr 20, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 20, 2023
@roman-r-m
Copy link
Collaborator

Will this not make the startup time of the portable version even worse? There were some complaints about this on the forum as I recall.

@laurent22
Copy link
Owner

Hmm, yes that's a good point. It would be nice if we could specify no compression for the portable app

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants