Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Fixes #9786: Rich text editor: Fix newline behavior in new notes #9809

Conversation

personalizedrefrigerator
Copy link
Collaborator

Summary

This fixes #9786 by adjusting the awfulBrHack (which seems to have caused the original issue).

Testing

  1. Switch to the rich text editor
  2. Create a new note
  3. Press the "bullet list" button
    • Verify that a list item is created
  4. Create a new note
  5. Type "this is a test", press enter, then type "new line"
  6. Press shift-enter, then type "test"
    • Verify that the just-created new line has less space above than the previous.
  7. Switch notes
  8. Switch back
  9. Verify that line spacing hasn't been lost.

This has been tested successfully on Ubuntu 23.10.

@laurent22 laurent22 merged commit 0e6b5b3 into laurent22:dev Feb 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants