Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremental compilation of the C code #7

Closed
LaurentMazare opened this issue Mar 2, 2019 · 2 comments
Closed

Incremental compilation of the C code #7

LaurentMazare opened this issue Mar 2, 2019 · 2 comments

Comments

@LaurentMazare
Copy link
Owner

It seems that the C wrappers get recompiled on pretty much any change. Using ccache makes it a bit better but we should try to fix this as it makes the development loop a bit slow.
A possibility could be to have a subcrate torch-sys which contains the C wrappers so that the C code only gets recompiled when parts of this new crate are modified.

@ehsanmok
Copy link
Contributor

ehsanmok commented Mar 2, 2019

I think sccache is the way to go and can be invoked in the future CI.

@LaurentMazare
Copy link
Owner Author

Nice, thanks for pointing this out. This will certainly help on the rust side of things too - I also went ahead and split some bits in a second torch-sys crate so slow compilation of the C++ code is not an issue anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants