Problem with dark editor theme #799

asampal · 2015-06-27T07:59:55Z

If the editor background color is set to black, it remains white except for the line number columns.

Eclipse 4.5, Windows 8.1
ccw.core 0.32.0.201506262242

laurentpetit · 2015-06-27T15:02:45Z

Reproduced.
@arichiardi do you think you'll have the possibiity to take a look, or at least point me in the right direction?

arichiardi · 2015-06-27T15:18:07Z

I think yes i will try this weekend, it should not be some issue with tokens, probably the background pref not read/set correctly

laurentpetit · 2015-06-27T20:25:01Z

Hello,

I have found the time to look at it and I think I have a solution. I will submit a PR for review, if you're ok with this?

—
Envoyé avec Mailbox

On Sat, Jun 27, 2015 at 5:18 PM, Andrea Richiardi
notifications@github.com wrote:

I think yes i will try this weekend, it should not be some issue with tokens, probably the background pref not read/set correctly

Reply to this email directly or view it on GitHub:
#799 (comment)

arichiardi · 2015-06-27T20:45:29Z

Oh yes please go ahead, i did not have time to
have a look but i will test it for sure

laurentpetit · 2015-06-27T21:34:34Z

@arichiardi the fix is in this commit, can you review it? 6fd012a

asampal · 2015-07-01T05:53:05Z

The fix works, but there is still a one character wide column that remains white, separating the line number area from the editing area.

laurentpetit · 2015-07-01T23:18:12Z

@asampal indeed, will work on this

arichiardi · 2015-07-03T10:07:38Z

After having debugged ClojureTokenScanner, I discovered that it was not related...
Probably folding is the culprit...https://stackoverflow.com/questions/12207637/eclipse-juno-how-to-change-background-of-code-folding-regions

arichiardi · 2015-07-03T10:31:51Z

Another related issue:
https://stackoverflow.com/questions/12490672/vertical-white-line-on-eclipse

@asampal could you try these two workarounds?

arichiardi · 2015-07-03T10:34:27Z

And finally:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=194313

laurentpetit · 2015-07-03T16:08:13Z

Yes, folding seems to be the issue. JDT does not have the problem.

arichiardi · 2015-07-03T17:10:51Z

Sorry I have posted a workaround for CDT, will try something better, for example I can try emulating what JDT is doing

asampal · 2015-07-03T19:29:37Z

Toggling the folding functionality didn't fix this for me. Closed the editors and re-opened, but no go.

laurentpetit · 2015-07-23T10:14:02Z

@arichiardi I'd like to focus on what's required to release a new stable version. This issue seems like an embarrassing regression to me. Better to fix it soon. Can you give it another try?

arichiardi · 2015-07-23T10:20:39Z

Yes ok I will focus on this then

laurentpetit · 2015-07-23T10:21:51Z

thanks a lot!

arichiardi · 2015-07-23T10:26:16Z

Don't mention it 😄 !

laurentpetit · 2015-07-28T19:30:22Z

Just to refresh my memory, I gave the current stable version a try, and it does not have the problem, indeed.
I tried to disable as many options as possible related to folding, but the problem remains the same, so it may not be related to the same problem people have reported on Stack Overflow.

Will try to bisect to find where the problem occurs.

laurentpetit · 2015-07-28T21:36:07Z

OK, so bisecting confirms that fcc360c is the first commit introducing the problem

laurentpetit · 2015-07-28T22:23:09Z

Well, big commit, hard to tell where the problem lies. Will try another approach and put some breakpoints in the StyledText

arichiardi · 2015-07-29T04:47:37Z

Will debug too, I remember I did change nothing about the tokens...it is weird because it looks like that stripe is not even within buffer range...I will help you out and sorry about it..

arichiardi · 2015-07-29T04:52:03Z

initializeViewerColors looks suspicious for instance, maybe it does not take the black background color

arichiardi · 2015-07-29T07:49:20Z

Another road I am considering: guari/eclipse-ui-theme#7

arichiardi · 2015-07-29T07:53:04Z

I put here the SWT spy log:

AnnotationRulerColumn$5 {}@140230138540928
    Style: NO_FOCUS | LEFT_TO_RIGHT | DOUBLE_BUFFERED 
    Layout Data: null
    Bounds: Rectangle {44, 0, 9, 206}


Children:

Peers:
    *AnnotationRulerColumn$5 {}@140230138540928 Layout Data: null Bounds: Rectangle {44, 0, 9, 206}
    AnnotationRulerColumn$5 {}@140230141853568 Layout Data: null Bounds: Rectangle {0, 0, 12, 206}
    LineNumberRulerColumn$4 {}@140230140489248 Layout Data: null Bounds: Rectangle {12, 0, 32, 206}

Parent Tree:
[CUT]

Canvas {}@139916372127008
                                                             Style: LEFT_TO_RIGHT | DOUBLE_BUFFERED 
                                                             Bounds: Rectangle {0, 0, 954, 276}
                                                             Layout: org.eclipse.jface.text.source.SourceViewer$RulerLayout@4a767290
                                                             LayoutData: null
                                                            CompositeRuler$CompositeRulerCanvas {}@139916355542160
                                                                 Style: LEFT_TO_RIGHT | DOUBLE_BUFFERED 
                                                                 Bounds: Rectangle {0, 0, 29, 258}
                                                                 Layout: org.eclipse.jface.text.source.CompositeRuler$RulerLayout@76b6b86f
                                                                 LayoutData: null

arichiardi · 2015-07-29T08:58:00Z

I am digging deep, basically the setBackground that follows correctly shows {255,0,0} the red I chose:

This is clear because we explicitely call styledText.setBacground in initializeViewerColors. But when AnnotationRulerColumn.redraw() is triggered, the background color on its fCanvas is {215,215,215}, which is that light gray you see...

Now, why in the world the color goes in the StyledText and not in the AnnotationRulerColumn I don't know...

laurentpetit · 2015-07-29T10:03:22Z

Yeah, I also already spent a night on this yesterday without success. But I'm stubborn, and I hope we'll find the problem. We may also learn things about how swt / jface / viewers work, along the way.

—
Envoyé avec Mailbox

On Wed, Jul 29, 2015 at 10:58 AM, Andrea Richiardi
notifications@github.com wrote:

I am digging deep, basically the setBackground that follows correctly shows {255,0,0} the red I chose:

But when AnnotationRulerColumn.redraw() is triggered, the background color on its fCanvas is {215,215,215}, which is that light gray you see...

Now, why in the world the color goes in the StyledText and not in the AnnotationRulerColumn I don't know...

Reply to this email directly or view it on GitHub:
#799 (comment)

arichiardi · 2015-07-29T17:20:02Z

By the way it still happens in my Mars with jdt...have you tried to put a color that contrasts your theme color? We'll better report this in here.

EDIT: restarting basically solves the problem...it looks like there is some problem with live changes only.

laurentpetit · 2015-07-29T18:59:39Z

Well, on my Mars, java editor does not seem to have problems, while clojure editor does.

arichiardi · 2015-07-29T19:01:50Z

Could also be OS related, or Eclipse related, I am running on linux and y target platform is kepler atm.

laurentpetit · 2015-07-29T19:14:10Z

Indeed. I think I can probably release with this problem anyway. It will
not be too late to fix it later, and it's kind of a shame that I'm holding
back all the good stuff that's been done since January !

2015-07-29 21:01 GMT+02:00 Andrea Richiardi notifications@github.com:

Could also be OS related, or Eclipse related, I am running on linux and y
target platform is kepler atm.

—
Reply to this email directly or view it on GitHub
#799 (comment).

Laurent Petit

laurentpetit · 2015-07-29T19:16:30Z

Here's what I have here, on OS X, running Mars :

arichiardi · 2015-07-29T19:22:01Z

That's true ;)

On July 29, 2015 9:14:10 PM GMT+02:00, Laurent Petit notifications@github.com wrote:

Indeed. I think I can probably release with this problem anyway. It
will
not be too late to fix it later, and it's kind of a shame that I'm
holding
back all the good stuff that's been done since January !

2015-07-29 21:01 GMT+02:00 Andrea Richiardi notifications@github.com:

Could also be OS related, or Eclipse related, I am running on linux
and y
target platform is kepler atm.

—
Reply to this email directly or view it on GitHub

#799 (comment).

Laurent Petit

Reply to this email directly or view it on GitHub:
#799 (comment)

-ar

arichiardi · 2015-08-25T20:12:33Z

Even with folding, this problem is still there...very weird.

arichiardi · 2015-08-25T20:13:17Z

I mean in my branch folding-feature

arichiardi · 2015-08-26T07:25:45Z

I have randomly tried commit ae2e517 and it still has the problem, it was older than fcc360c

arichiardi · 2015-08-26T07:56:34Z

In my Mars with Color Theme installed I went to Text Editors and reset to default colors...and...

It looks like this bug is hidden in JDT, but it is still there...but still, we should try to fix it in CCW first.

arichiardi · 2015-08-27T17:33:05Z

Good news! I solved the problem!

arichiardi · 2015-08-27T18:34:02Z

It will be in thn folding-feature because it is directly related with it, difficult to extrapolate...

laurentpetit · 2015-08-28T07:50:46Z

Good news indeed! What was the problem?

arichiardi · 2015-08-28T07:54:14Z

When you change the background basically, because of the above-mentioned bug, you need to toggle the folding on PrjectionViewer.
I am planning to do it automagically thanks to your whiteboard pattern and listening to the background preference.

laurentpetit · 2015-08-28T08:00:53Z

(y)

arichiardi · 2015-08-28T08:05:58Z

Actually just listening to the background should suffice..

laurentpetit added the Priority-High label Jun 27, 2015

laurentpetit added this to the 0.32.0 milestone Jun 27, 2015

laurentpetit assigned arichiardi Jun 27, 2015

laurentpetit closed this as completed in 6fd012a Jun 27, 2015

laurentpetit reopened this Jul 1, 2015

arichiardi mentioned this issue Jul 29, 2015

Folding option in C editor guari/eclipse-ui-theme#3

Closed

laurentpetit modified the milestones: next, 0.32.0 Jul 29, 2015

arichiardi mentioned this issue Aug 31, 2015

Folding feature #846

Open

Problem with dark editor theme #799

Problem with dark editor theme #799

Comments

asampal commented Jun 27, 2015

laurentpetit commented Jun 27, 2015

arichiardi commented Jun 27, 2015

laurentpetit commented Jun 27, 2015

I think yes i will try this weekend, it should not be some issue with tokens, probably the background pref not read/set correctly

arichiardi commented Jun 27, 2015

laurentpetit commented Jun 27, 2015

asampal commented Jul 1, 2015

laurentpetit commented Jul 1, 2015

arichiardi commented Jul 3, 2015

arichiardi commented Jul 3, 2015

arichiardi commented Jul 3, 2015

laurentpetit commented Jul 3, 2015

arichiardi commented Jul 3, 2015

asampal commented Jul 3, 2015

laurentpetit commented Jul 23, 2015

arichiardi commented Jul 23, 2015

laurentpetit commented Jul 23, 2015

arichiardi commented Jul 23, 2015

laurentpetit commented Jul 28, 2015

laurentpetit commented Jul 28, 2015

laurentpetit commented Jul 28, 2015

arichiardi commented Jul 29, 2015

arichiardi commented Jul 29, 2015

arichiardi commented Jul 29, 2015

arichiardi commented Jul 29, 2015

arichiardi commented Jul 29, 2015

laurentpetit commented Jul 29, 2015

Now, why in the world the color goes in the StyledText and not in the AnnotationRulerColumn I don't know...

arichiardi commented Jul 29, 2015

laurentpetit commented Jul 29, 2015

arichiardi commented Jul 29, 2015

laurentpetit commented Jul 29, 2015

laurentpetit commented Jul 29, 2015

arichiardi commented Jul 29, 2015

arichiardi commented Aug 25, 2015

arichiardi commented Aug 25, 2015

arichiardi commented Aug 26, 2015

arichiardi commented Aug 26, 2015

arichiardi commented Aug 27, 2015

arichiardi commented Aug 27, 2015

laurentpetit commented Aug 28, 2015

arichiardi commented Aug 28, 2015

laurentpetit commented Aug 28, 2015

arichiardi commented Aug 28, 2015

Now, why in the world the color goes in the `StyledText` and not in the `AnnotationRulerColumn` I don't know...