Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document adler32 hashing algorithm #4

Open
rillig opened this issue May 26, 2015 · 1 comment
Open

Document adler32 hashing algorithm #4

rillig opened this issue May 26, 2015 · 1 comment

Comments

@rillig
Copy link

rillig commented May 26, 2015

The Adler32 checksumming algorithm in src/core/hash/adler.c needs to be documented and verified that it meets its specification. Currently it fails on x86 because char is a signed data type on that platform. See https://github.com/lavabit/libdime/blob/master/check/core/check_hash.c for the check in libdime.

@rillig
Copy link
Author

rillig commented May 26, 2015

Am 26.05.2015 um 22:46 schrieb Ivan:

I believe this is one of the things that Roland already fixed in
libdime/libs/core, but is still an issue in magma.classic.

If you pull down libdime from github and you do a diff between the two
files you will see the changes. There is also a unit test that he wrote
that he linked to which does not exist in magma.

Confirmed.

Roland

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant