-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 0000-01-02-lavaniab.md #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good pull requests have a body description that tells other contributors about the change you're suggesting, so they understand the context.
Let's edit this pull request to add a body description.
⌨️ Activity: Fixing your pull request
- The first comment on your pull request will have the default text of No description provided. Click on the ... icon located at the top right corner of the comment box, then click on Edit to make an edit
- Add a description of the changes you've made in the comment box. Feel free to add a description of what you’ve accomplished so far. As a reminder, you have: created a branch, created a file and made a commit, and opened a pull request
- Click the green Update comment button at the bottom right of the comment box when done
If you would like assistance troubleshooting the issue you are encountering, create a post on the GitHub Community board. You might also want to search for your issue to see if other people have resolved it in the past.
I'll respond when I detect this pull request's body has been edited.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Step 7: Respond to a review
Your pull request is looking great!
Let’s add some content to your file. Replace line 5 of your file with a quotation or meme and witty caption. Remember: Markdown is supported.
⌨️ Activity: Change your file
- Click the Files Changed tab in this pull request
- Click on the pencil icon found on the right side of the screen to edit your newly added file
- Replace line 5 with something new
- Scroll to the bottom and click Commit Changes
I'll respond when I detect a commit on this branch.
Hi @lavaniab! It looks like the bot is waiting for you to edit the file. I think you've left reviews or comments on the file, but it's expecting you to go to the Files changed tab, then click the small grey pencil, and change line five from "Your text" to something new. Give that a try, and let me know if you still need help. 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Step 8: Merge your pull request
Nicely done @lavaniab! ✨
You successfully created a pull request, and it has passed all of the tests. You can now merge your pull request.
⌨️ Activity: Merge the pull request
-
Click Merge pull request
-
Click Confirm merge
-
Once your branch has been merged, you don't need it anymore. Click Delete branch.
I'll respond when this pull request is merged.
Nice workCongratulations @lavaniab, you've completed this course! What went wellNow, you have your slide deck deployed here and you've gone through the GitHub Flow. Before I say good-bye, here's a recap of all the tasks you've accomplished in your repository:
What's next?We hope this course helped you feel more comfortable using GitHub. Remember: You’re always welcome to repeat course topics if you’d like additional practice. If you’re ready to build on your new skills, here are some ideas. Contribute to a projectTo find projects to contribute to through trending topics and curated collections, check out GitHub Explore. Keep learningHere are some suggestions for future courses you can take:
|
Have created a branch, created a file and made a commit and opened a pull request