Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is illuminate/support a dependency? #4

Closed
boosis opened this issue Apr 22, 2016 · 4 comments
Closed

Why is illuminate/support a dependency? #4

boosis opened this issue Apr 22, 2016 · 4 comments

Comments

@boosis
Copy link

boosis commented Apr 22, 2016

I haven't used this yet, but could you tell me why illuminate/support is a dependency? I didn't see where you used this library.

@rossbearman
Copy link

The only usage I can find in the code is the Mailer contract Illuminate\Contracts\Mail\Mailer in Event.php.

illuminate/support shouldn't be a dependency of a framework-agnostic package as it is a huge package itself, with a number of dependencies. It's intended to provide support packages for the Laravel framework itself and not really intended for use elsewhere, unless you're building a Laravel specific package that can be tied to a specific Laravel version.

@boosis
Copy link
Author

boosis commented Apr 22, 2016

Yes, I saw that. Even there it's only namespace, Mailer class is not used anywhere in that class

@lavary
Copy link
Owner

lavary commented Apr 23, 2016

@rossbearman illuminate/support was used for a couple of helper functions like array_get(), array_only, collect, and a few others. However, this dependency has been removed in the latest release of Crunz, which is 1.1.1.

The reference to Illuminate\Contracts\Mail\Mailer has been removed as well.

@rossbearman
Copy link

Good job, thanks for resolving this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants