Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onValueChange double toggle after i selected. #58

Closed
lyseiha opened this issue Jul 17, 2018 · 5 comments
Closed

onValueChange double toggle after i selected. #58

lyseiha opened this issue Jul 17, 2018 · 5 comments

Comments

@lyseiha
Copy link

lyseiha commented Jul 17, 2018

No description provided.

@lyseiha lyseiha changed the title onValueChange twin toggle after i selected. onValueChange double toggle after i selected. Jul 17, 2018
@lyseiha lyseiha closed this as completed Jul 17, 2018
@JulianKingman
Copy link

This is probably because of the 4.0.0 release, how did you handle it? https://github.com/lawnstarter/react-native-picker-select/releases/tag/4.0.0

@baqirhabsyi
Copy link

baqirhabsyi commented Aug 6, 2018

Hey @lyseiha, I encountered the same problem. Did you find out how to fix this behavior? Btw, @JulianKingman do you know of any workaround of this problem?

@DenisBogatirov
Copy link

This is still an issue.
@JulianKingman Who does need this logic? https://github.com/lawnstarter/react-native-picker-select/releases/tag/4.0.0

You fire change event which fires re-render with new calue, which fires change event again?

I am trying to use it with Redux-Form and it fires change event with old value

@lfkwtz
Copy link
Collaborator

lfkwtz commented Sep 26, 2018

This change occurred via #45 - it's been out for almost 3mo now and there haven't been issues opened aside from this thread - but I'm interested in how this is negatively impacting you.

I just added some more tests locally and i'm not seeing the issue you're describing @DenisBogatirov - can you reproduce it somewhere?

I could potentially add a flag to disable this...

@jarredkenny
Copy link

I am seeing this as well on v8.1.0 and am getting around it by debouncing the on change handler, not ideal.

Would love a flag to turn off this behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants