Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange output #31

Closed
nayab9 opened this issue Jan 20, 2020 · 5 comments
Closed

Strange output #31

nayab9 opened this issue Jan 20, 2020 · 5 comments

Comments

@nayab9
Copy link

nayab9 commented Jan 20, 2020

As far as I can tell, instawow is working as expected. It will list all my addons and it will update them too; the only strange part is the following output after it completes tasks:

Exception ignored in: <function _ProactorBasePipeTransport.__del__ at 0x03ECF8E0>
Traceback (most recent call last):
  File "c:\users\varian\appdata\local\programs\python\python38-32\lib\asyncio\proactor_events.py", line 116, in __del__
    self.close()
  File "c:\users\varian\appdata\local\programs\python\python38-32\lib\asyncio\proactor_events.py", line 108, in close
    self._loop.call_soon(self._call_connection_lost, None)
  File "c:\users\varian\appdata\local\programs\python\python38-32\lib\asyncio\base_events.py", line 715, in call_soon
    self._check_closed()
  File "c:\users\varian\appdata\local\programs\python\python38-32\lib\asyncio\base_events.py", line 508, in _check_closed
    raise RuntimeError('Event loop is closed')
RuntimeError: Event loop is closed

Any ideas what this output is? It doesn't seem to be negatively impacting the usage of instawow from what I can tell.

@layday
Copy link
Owner

layday commented Jan 20, 2020

This is (was) a latent bug in aiohttp, the networking library I'm using. What would previously cause an innocuous ResourceWarning manifests as an exception in Python 3.8 on Windows. It will be fixed in the next version of aiohttp. You are correct that this does not interrupt other operations but I'll think about what (if anything) I can do to work around the issue until the fix is published.

See https://bugs.python.org/issue39232 and aio-libs/aiohttp#4324 for the gory details.

@nayab9
Copy link
Author

nayab9 commented Jan 20, 2020

Thanks for the info! Will continue using either way, cannot live without instawow!

P.s. do you have an Ethereum or Bitcoin Cash adress so I can buy you a beer? 🍻

@layday
Copy link
Owner

layday commented Jan 20, 2020

Afraid not but thanks for offering!

@layday layday closed this as completed in e06dd18 Jan 20, 2020
@layday
Copy link
Owner

layday commented Jan 20, 2020

I decided to take the easy route and force 3.8 to use the 3.7 loop. I'll release a new version of instawow containing the fix later today.

@layday
Copy link
Owner

layday commented Jan 20, 2020

Fixed in v1.7.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants