Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snapshots are failing. #41

Closed
leecalcote opened this issue Jul 31, 2023 · 3 comments
Closed

Snapshots are failing. #41

leecalcote opened this issue Jul 31, 2023 · 3 comments
Assignees
@Abhishek-kumar09
Labels
kind/bug Something isn't working priority/high

Comments

@leecalcote
Copy link
Contributor

leecalcote commented Jul 31, 2023 •
edited
Loading

Describe the bug
Snapshots are failing.

Example - https://github.com/meshery/meshery/actions/runs/5718720204/job/15495104794#step:5:176
@leecalcote leecalcote added the kind/bug Something isn't working label Jul 31, 2023
@Abhishek-kumar09
Copy link
Contributor

#42

@leecalcote
Copy link
Contributor Author

leecalcote commented Oct 16, 2023 •
edited
Loading

I have disabled, the MeshMap Snapchat workflow in the meshery/meshery repo. It has been failing for a couple months. As this seems to be a failed project, I'll propose that this repo be archived.

@Abhishek-kumar09
Copy link
Contributor

Abhishek-kumar09 commented Oct 16, 2023 •
edited
Loading

The tests are failing not because the workflow not working. With the changes in the UI, there has to be follow-up changes in cypress automation as well, since the UI is behind the generation of snapshot. The UI automation has been done through cypress, and its because of that you see the snapshots going.

I cannot see recent logs, but the last log I had seen some time back was the cypress automation failure.

Secondly, I think playwright tests have been failing to generate results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Abhishek-kumar09 Abhishek-kumar09

Labels
kind/bug Something isn't working priority/high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leecalcote @Abhishek-kumar09