You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 20, 2019. It is now read-only.
So, even Extract::MODE_ALLOW_ICANN will not help you there, php-domain-parser has a same issue there because it uses the same database. However, test.ru should be suffix in this case.
Wouldn't this be fixed by changing the code here (line 225-227 of Extract.php)
if ($suffix === $hostname) {
return [null, $hostname, null];
}
to this:
if ($suffix === $hostname) {
return [null, null, $hostname];
}
?
Is there a reason the suffix is being placed in the "hostname" when there's just a suffix?
You can still work around it, I suppose, since the TLDDatabase library is a dependency, you can just use that pacakge to check if the string is a public suffix first.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I have tested with hundred of domains, but for the domain test.ru i get the following result:
The text was updated successfully, but these errors were encountered: