Task: add CI job to run cargo test #44
Conversation
.github/workflows/rust_tests.yml
Outdated
| matrix: | ||
| os: | ||
| [ | ||
| [self-hosted, ubuntu-20.04], |
There was a problem hiding this comment.
Could you tell me the reason why you use self-hosted Ubuntu rather than ubuntu-latest?
There was a problem hiding this comment.
The reason for that is that I saw the README inside the directory .github/workflows and the unit test workflow of other languages like Java/Go/Typescript, all of them used the self-hosted Ubuntu. However, I found that it is probably better for us to use the latest as we don't really host the machines.
.github/workflows/rust_tests.yml
Outdated
| schedule: | ||
| - cron: "10 2 * * *" | ||
| push: | ||
| branches: ["master", "release-*", "rust"] |
There was a problem hiding this comment.
We are currently using rust_sdk branch, not rust.
| branches: ["master", "release-*", "rust"] | |
| branches: ["master", "release-*", "rust_sdk"] |
.github/workflows/rust_tests.yml
Outdated
| os: | ||
| [ | ||
| [self-hosted, ubuntu-20.04], | ||
| macos-latest, | ||
| [self-hosted, windows-server-2019], | ||
| ] |
There was a problem hiding this comment.
IMO, we don't need need to run clippy from various OSes.
.github/workflows/rust_tests.yml
Outdated
| os: | ||
| [ | ||
| [self-hosted, ubuntu-20.04], | ||
| macos-latest, | ||
| [self-hosted, windows-server-2019], | ||
| ] |
There was a problem hiding this comment.
IMO, we don't need need to run cargo fmt from various OSes.
.github/workflows/rust_tests.yml
Outdated
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| os: [[ubuntu-latest], macos-latest, [windows-latest]] |
There was a problem hiding this comment.
Still using 3 OSes. IMO, ubuntu-latest here would be enough.
See: #44 (comment)
.github/workflows/rust_tests.yml
Outdated
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| os: [[ubuntu-latest], macos-latest, [windows-latest]] |
.github/workflows/rust_tests.yml
Outdated
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| os: [[ubuntu-latest], macos-latest, [windows-latest]] |
There was a problem hiding this comment.
[nits] We shouldn't need nested array here.
| os: [[ubuntu-latest], macos-latest, [windows-latest]] | |
| os: [ubuntu-latest, macos-latest, windows-latest] |
There was a problem hiding this comment.
Sorry for that, I have removed windows-latest and added a TODO now.
| toolchain: stable | ||
| - name: Run Cargo test | ||
| working-directory: ./sdks/rust | ||
| run: cargo test -- --skip target/debug |
There was a problem hiding this comment.
Tests in Windows is failing, maybe because of directory separator (/, /).
https://github.com/laysakura/beam/actions/runs/5257026192/jobs/9504117799?pr=44
There was a problem hiding this comment.
Probably need to have a look at Windows environment in detail.
There was a problem hiding this comment.
Or you might skip windows-latest for now (with some TODO comment).
|
@Kelvinyu1117 Thanks! |
This PR is for addressing issue #8 .