Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3: Fix test failures #7

Merged
merged 1 commit into from
Apr 9, 2023

Conversation

dahlbaek
Copy link
Collaborator

@dahlbaek dahlbaek commented Apr 9, 2023

  • Fix GroupByKey test by using KV instead of tuple.
  • Fix data race when writing to SERIALIZED_FNS.
  • Enable ensure_assert_fails test which was presumably previously causing spurious failures due to data race.

Fixes #3

- Fix GroupByKey test by using KV instead of tuple.
- Fix data race when writing to SERIALIZED_FNS.
- Enable ensure_assert_fails test which was presumably previously causing
  spurious failures due to data race.
@dahlbaek dahlbaek requested a review from laysakura April 9, 2023 00:20
@dahlbaek dahlbaek self-assigned this Apr 9, 2023
Copy link
Owner

@laysakura laysakura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thank you.

@laysakura laysakura merged commit 28b838e into laysakura:rust_sdk Apr 9, 2023
This was referenced Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants