-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port ParDo, GBK, etc. from other rust project. #22
Conversation
Also fix some bugs in construction and add tests.
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions. |
@robertwb Hi. I'm trying to develop Rust SDK with you guys! How to reproducewhile cargo test -- --skip target/debug ; do echo '' ; done Failure examples
|
My guess here is that this is caused by two things. That map needs to be replaced anyway, since it would be empty if you were to run pipeline construction and execution in separate processes or machines. I'm thinking of replacing that with bincode, serde and typetag for trait objects, but let's not dwell on that for too long right now. |
@nivaldoh @laysakura Merge this first and then have a look at the other PRs? |
@sjvanrossum in case you're interested, the race was removed in laysakura#7 and related to the mutex as you expected. |
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions. |
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
Also fix some bugs in construction and add tests.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.