Memory errors, segfaults and thread safety

[layters]

Details

Segmentation faults occur sometimes

• when a node receives a map query request and Node::map() is called.
• when a node adds a node to the routing table on ping via Node::on_ping()

These segfaults tend to occur when the network grows to a large size like about 20+ nodes.

I generally suck at memory management and handling pointers so any help would be greatly appreciated!
And if its not a memory management issue then this may have to do with accessing the node from multiple threads simultaneously.

Segment faults upon closing GUI application - Details

This segfault happens when closing the GUI while logged in, but it never occurs while not logged in yet and you are still at the main login page.

This may have to do with the code in a destructor in one of the classes. wallet.cpp is a suspect.

Sometimes the error is not a Segfault but similar:

double free or corruption (fasttop)
Aborted (core dumped)

---

Files and references

https://github.com/larteyoh/testshop/blob/main/src/core/protocol/p2p/node.cpp
https://github.com/larteyoh/testshop/blob/main/src/core/protocol/p2p/mapper.cpp

Bounty reward

$20