Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple render format constructors #64

Closed
4 tasks done
Lazerbeak12345 opened this issue Feb 25, 2022 · 5 comments
Closed
4 tasks done

Multiple render format constructors #64

Lazerbeak12345 opened this issue Feb 25, 2022 · 5 comments
Labels
enhancement New feature or request
Milestone

Comments

@Lazerbeak12345
Copy link
Owner

Lazerbeak12345 commented Feb 25, 2022

Is your feature request related to a problem? Please describe.
The library only supports browsers right now.

Describe the solution you'd like
Add constructors for:

  • StringRenderer
  • Ctd2dRenderer (current)
  • [ ] WebGL render targets #68
  • MultiRenderer to pipe render output to more than one other renderer

Take a renderer (as seen above) as the first and only argument to PIxelManipulator. The renderer will tell PixelManipulator the canvas sizes.

Describe alternatives you've considered

Additional context
The addElement function will need significant rework to define what color (or string, etc.) each element is using. The data would be passed to the renderer when an element is modified or added.

Relies on changes made in #53

  • Separate renderers to different file if possible.
@Lazerbeak12345 Lazerbeak12345 added the enhancement New feature or request label Feb 25, 2022
@Lazerbeak12345 Lazerbeak12345 added this to the Version 5 milestone Feb 25, 2022
@Lazerbeak12345
Copy link
Owner Author

in a3356af I added a SplitRenderer that is like MultiRenderer but it only supports two renderers.

@Lazerbeak12345
Copy link
Owner Author

According to the typescript documentation, that's the only way to do it.

Lazerbeak12345 added a commit that referenced this issue Mar 27, 2022
@Lazerbeak12345
Copy link
Owner Author

Lazerbeak12345 commented Mar 28, 2022

Just made a .dot file of the current structure of this app.

@Lazerbeak12345
Copy link
Owner Author

Working on a way to modularize. At a glance, it doesn't seem to be doable without extreme restructuring - and even then the zoomelm is too tightly bound to the Pixelmanipulator Instance

@Lazerbeak12345
Copy link
Owner Author

It seems that most of the modularization issues around the zoom element involve the current absence of an onupdate function.

It's worth looking into the whole event system to see where it can be improoved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant