Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore COPYING #33

Closed
jamesjer opened this issue Oct 24, 2019 · 8 comments · Fixed by #39
Closed

Restore COPYING #33

jamesjer opened this issue Oct 24, 2019 · 8 comments · Fixed by #39

Comments

@jamesjer
Copy link
Contributor

The old tarball had a COPYING file containing the text of GPLv3. That file did not make the transition to github, it seems.

@olexandr-konovalov
Copy link
Collaborator

Thanks - this will also tick a box in #1. Where is the old tarball so we can check?

@jamesjer
Copy link
Contributor Author

I'm afraid I don't know how to find the old tarball anymore. I've got a copy I downloaded in 2015 for the purposes of creating a carat package for Fedora. It's up in the Fedora build system, but I don't know if there is a way for the general public to access it. If you know how to unpack an RPM, you can get it out of the latest build: https://kojipkgs.fedoraproject.org/packages/carat/2.1b1.19.07.2008/13.fc31/src/carat-2.1b1.19.07.2008-13.fc31.src.rpm

@olexandr-konovalov
Copy link
Collaborator

Indeed https://web.archive.org/web/20160817084957/http://wwwb.math.rwth-aachen.de/carat/carat.tgz has COPYING with GPLv3. Perhaps there were different archives lying around when this repository was created...

@jamesjer
Copy link
Contributor Author

Oh yes, I remember now. On May 18, 2015 I sent an email to the carat maintainers with a few patches, and I asked about the license at that time. They created a new tarball on May 21 with the license file and the patches applied, but did not change either the version number or the name of the tarball. I thought at the time that that was a bad idea....

@gaehler
Copy link
Collaborator

gaehler commented Oct 24, 2019

My GAP package Carat version 2.2.3 contains that tarball, including the COPYING file.

@olexandr-konovalov
Copy link
Collaborator

Glad that we have evidence and memories :) Is there anything else in that tarball? What about those few patches - are they still relevant, already applied, or obsolete?

@jamesjer
Copy link
Contributor Author

jamesjer commented Oct 24, 2019

Kind of a mix, I'm afraid. Some parts were fixed anew in the recent warning cleanup commit, some are still as they were originally. I just submitted pull request #34, which applies the rest and does some additional warning cleanup.

@fingolfin
Copy link
Collaborator

I just merged PR #34 (didn't even know I had the permissions to do that ;-).

We actually got permission to put this code under GPL 2 or later, so I think we should do that. I just created PR #39 to this end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants