Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default ports for docker-compose file #26

Closed
tanhongit opened this issue Apr 27, 2023 · 0 comments · Fixed by #29
Closed

Add default ports for docker-compose file #26

tanhongit opened this issue Apr 27, 2023 · 0 comments · Fixed by #29
Assignees
Labels
enhancement New feature or request

Comments

@tanhongit
Copy link
Member

Currently, the ports and app names in the docker-compose file are being called directly from the environment variables in the .env file.

This is very detrimental because in some cases users do not pay attention to this configuration request and ignore it to proceed with running the build command.
In that case, it will cause an error because the ports are unknown.

So I need a condition that if the environment variables do not exist, I will get the default port to avoid the above error.

@tanhongit tanhongit added the enhancement New feature or request label Apr 28, 2023
@tanhongit tanhongit self-assigned this Apr 28, 2023
tanhongit added a commit to tanhongit/lemp-docker that referenced this issue Apr 28, 2023
tanhongit added a commit to tanhongit/lemp-docker that referenced this issue Apr 28, 2023
(cslant#26) Add default ports for docker-compose file
@tanhongit tanhongit linked a pull request Apr 28, 2023 that will close this issue
tanhongit added a commit that referenced this issue Apr 28, 2023
Add default ports for docker-compose file #26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant