Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move front end/backend into separate repos? #44

Closed
marksverdhei opened this issue Nov 29, 2021 · 7 comments · Fixed by #50
Closed

Move front end/backend into separate repos? #44

marksverdhei opened this issue Nov 29, 2021 · 7 comments · Fixed by #50
Assignees
Labels
approved Suggestion approved discussion

Comments

@marksverdhei
Copy link
Collaborator

Perhaps it's more clean given that the programs can be run independently.
Wdyt?

@LBlend
Copy link
Owner

LBlend commented Nov 29, 2021

I agree, though it will take some work. It'll be a task for the holidays when I've got the time for it.

I'm thinking of keeping the backend in this repo and moving the frontend to a separate one called "mann-eller-kvinne-frontend" or something among those lines.

@marksverdhei
Copy link
Collaborator Author

marksverdhei commented Nov 29, 2021

Would be pretty cool. At the moment, I'm fantasizing about replicating the API using some different technologies such as

  • FastAPI
  • sklearn for simple models
  • pretrained embeddings for the neural model
  • kubernetes with e.g. minikube
    Of course, this can be done in a fork, or different repos
    It might even be worth considering replacing the main thing with this, if it turns out better 😛

@LBlend
Copy link
Owner

LBlend commented Nov 30, 2021

Sounds good to me! I'm open to the idea of rewriting the backend i.e. using some if not all of the technologies you've mentioned. I find it hard to see the point of adding kubernetes support though, but other than that I agree.

@marksverdhei
Copy link
Collaborator Author

In this use case, it might not be necessary, but if we were to care about dynamic scalability and minimal downtime
it could be useful. Plus submitting / scheduling training jobs through kubernetes.
I think it could be nice, when showing this project to e.g. future employers that we really took the extra
steps (to give it the potential) to be scalable and robust as if it was for a business use case (which everything else is).

Note that none of this has to be hosted by you. You can still do it the old fashioned way.
Most likely it will just be a folder with a couple yaml files that lets you plug your app/api right into any kubernetes cluster
Minikube requires at least 2 GB of memory and (I think) 20 gb of

Wouldn't it be pretty neat to have kubernetes on your resume? 😎

@LBlend
Copy link
Owner

LBlend commented Nov 30, 2021

True true 👀

@LBlend
Copy link
Owner

LBlend commented Nov 30, 2021

This calls for a rewrite of the frontend as well. It should be pretty easy to do and can be done in a couple of hours. I will get started on that in the near future

@LBlend LBlend added approved Suggestion approved and removed backend labels Dec 12, 2021
@LBlend LBlend pinned this issue Dec 12, 2021
@LBlend
Copy link
Owner

LBlend commented Dec 16, 2021

I have now made a branch called "rewrite" in this repo and have started making some initial changes. I'll come back to you once the base structure of the rewrite is complete and (partially) working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Suggestion approved discussion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants