Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hub Federation (hub-side) #6

Closed
6 tasks done
lyoshenka opened this issue Jun 15, 2021 · 4 comments
Closed
6 tasks done

Hub Federation (hub-side) #6

lyoshenka opened this issue Jun 15, 2021 · 4 comments
Assignees

Comments

@lyoshenka
Copy link
Member

lyoshenka commented Jun 15, 2021

The goal of hub federation is to allow clients to find out about hubs they don't know about.

  • hub stores it's list of known peers (other hubs) on disk. list starts empty if no hubs are known
  • on startup, load saved peers from disk
  • add grpc endpoint that adds a peer to the list of known peers (and stores it to disk). if the peer is new, the hub also announces itself to the peer so the peer knows about it
  • on startup, hub should announce itself to all known peers
  • add config to disable federation. if set, the peer-adding rpc does nothing and the hub does not announce itself to other peers. but the starting list of seed hubs still lets it know about other hubs.
  • figure out how connecting to other hubs and staying connected works.

do not allow non-LBRY-Inc hubs to peer with us until claim proofs are re-enabled (#2183). this prolly means having federation disabled on hubs by default.

questions

  • does any of the python code need to be brought to Go? (e.g. peer manager, udp announcement)
  • should hubs prune their peer list? how do they detect peers that are offline, peers that are fake, etc?
  • should hubs validate peers somehow?
@lyoshenka
Copy link
Member Author

Victor will have the first two checkboxes done before standup on Wednesday

@lyoshenka
Copy link
Member Author

lyoshenka commented Jul 19, 2021

The last day to do anything on this is July 30th. After that we're merging whatever's done and switching issues.

@lyoshenka
Copy link
Member Author

victor didn't do much on this and now he's working with jack to finish the leveldb/reorg work

@jeffreypicard jeffreypicard self-assigned this Oct 11, 2021
@jeffreypicard
Copy link
Collaborator

jeffreypicard commented Nov 24, 2021

#24

@kauffj kauffj closed this as completed Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants