Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to protobuf==3.18.3 within lbry-sdk repo causes MacOS unit test failures #121

Open
moodyjon opened this issue Jan 16, 2023 · 1 comment · May be fixed by #119
Open

Bump to protobuf==3.18.3 within lbry-sdk repo causes MacOS unit test failures #121

moodyjon opened this issue Jan 16, 2023 · 1 comment · May be fixed by #119
Assignees
Labels
priority: high Work needs to be moved into sprint ASAP

Comments

@moodyjon
Copy link
Contributor

Hub/setup.py protobuf version was bumped in this change:

75d64f9

However, when I try to apply a corresponding change in lbry-sdk/setup.py:

(lbry-venv) swdev1@Jonathans-Mac-mini lbry-sdk % git diff
diff --git a/setup.py b/setup.py
index bd468c687..4c736f646 100644
--- a/setup.py
+++ b/setup.py
@@ -37,7 +37,7 @@ setup(
         'base58==1.0.0',
         'cffi==1.13.2',
         'cryptography==2.5',
-        'protobuf==3.17.2',
+        'protobuf==3.18.3',
         'prometheus_client==0.7.1',
         'ecdsa==0.13.3',
         'pyyaml==5.3.1',
@@ -57,7 +57,7 @@ setup(
             'jsonschema==4.4.0',
         ],
         'hub': [
-            'hub@git+https://github.com/lbryio/hub.git@929448d64bcbe6c5e476757ec78456beaa85e56a'
+            'hub@git+https://github.com/lbryio/hub.git@75d64f9dc6d3b2c913b8b10053bd3589e7a2e8eb'
         ]
     },
     classifiers=[

The MacOS unit tests start to fail:

https://github.com/moodyjon/lbry-sdk/actions/runs/3933945634

I'm uncertain whether this is due to use of "coverage" tool, GitHub CI, or OS/arch issue.

Unit tests work fine when run locally on my machine (MacOS 13.1 / arm64). I have a development branch which was bumped to "protobuf==3.20.1" for other reasons (stringmap_extensions), and it didn't have the same effect of breaking the test.

@moodyjon moodyjon added the priority: high Work needs to be moved into sprint ASAP label Jan 16, 2023
@moodyjon
Copy link
Contributor Author

This blocks linking to a new version of hub in lbry-sdk/setup.py. I think the change should be reverted, or we go to a higher version of protobuf that does not have the same problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high Work needs to be moved into sprint ASAP
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant