getblocktemplate does not show SigWit feature in Stratum

[roylee17]

This might need changes on either Stratum or lbcd side, such as magic number, coin symbols, etc.

[roylee17]

Update:

Stratum tries to parse the rules field to find the segwit support, but lbcd only appends segwit to rules if the blocktemplate includes any segwit transactions.

Will update again after consulting BIP 145.

[roylee17]

Update:

• The "segwit" of the rules field is optional when there's no SegWit transactions (inputs) in the template.
• The default_witness_commit field is optional when there's no SegWit transactions (inputs) in the template.

lbcd does correctly implement the above behaviors - populate both fields when SwgWit inputs are included in the template, and omit both of the fields otherwise. However, the default_witness_commit returned is raw commitment instead of the witness script. (see issue #20)

This poses 2 questions:

1. How come lbrycrd always populates SegWit fields in getblocktemplate response?
2. Does Stratum mandate the presence of SegWit fields?

[roylee17]

The Segwit related fields such as default_witness_commitment and rules ["segwit"] is required only when a template includes SegWit transactions.