Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow batching of transactions, including publishes/updates #1821

Open
10 tasks
tzarebczan opened this issue Jan 28, 2019 · 4 comments
Open
10 tasks

Allow batching of transactions, including publishes/updates #1821

tzarebczan opened this issue Jan 28, 2019 · 4 comments
Labels
area: wallet consider soon Discuss this issue at the next planning meeting, then remove this label priority: medium Work needs to be done within 2-3 sprints type: new feature New functionality that does not exist yet

Comments

@tzarebczan
Copy link
Contributor

The Issue

The SDK should allow support for batching of transactions. This will make large claim updates or publishes possible in a single transaction, which is especially useful for YouTube sync claim updates we plan to make after adding new metadata.

On the transaction list side, should these appear as a single entry with a "batch" tx type/details area?

System Configuration

  • LBRY Daemon version:
  • LBRY App version:
  • LBRY Installation ID:
  • Operating system:

Anything Else

Screenshots

Internal Use

Acceptance Criteria

Definition of Done

  • Tested against acceptance criteria
  • Tested against the assumptions of user story
  • The project builds without errors
  • Unit tests are written and passing
  • Tests on devices/browsers listed in the issue have passed
  • QA performed & issues resolved
  • Refactoring completed
  • Any configuration or build changes documented
  • Documentation updated
  • Peer Code Review performed
@tzarebczan tzarebczan added area: wallet type: new feature New functionality that does not exist yet consider soon Discuss this issue at the next planning meeting, then remove this label labels Jan 28, 2019
@alyssaoc alyssaoc added priority: low Work should be done but can stay in the backlog for now and removed consider soon Discuss this issue at the next planning meeting, then remove this label labels Mar 20, 2019
@tzarebczan
Copy link
Contributor Author

Reopening this because it's also a potential solution to what Niko is running into with mass updating/publishing on YouTube sync.

I think there are many more use cases for this in the app and other mass publishing program as well. One example is a user who clears their channel key and wants to republish/update all his content using the new one.

@tzarebczan tzarebczan reopened this Jun 17, 2019
@tzarebczan tzarebczan added priority: medium Work needs to be done within 2-3 sprints and removed priority: low Work should be done but can stay in the backlog for now labels Jul 24, 2019
@tzarebczan
Copy link
Contributor Author

We have scenarios where users may want to move all their claims from one channel to another, or all anonymous claims (or some subset of claim ids) to a channel.

@jessopb
Copy link
Member

jessopb commented Nov 2, 2022

We discussed how various tools might want to batch transactions for tips, supports, reposts, etc.
In short discussion, Lex said he most supported doing lbrynet --batch=[<some list of commands>]

@jessopb jessopb added the consider soon Discuss this issue at the next planning meeting, then remove this label label Nov 3, 2022
@jessopb
Copy link
Member

jessopb commented Nov 3, 2022

Doing anything wholesale with the sdk requires coin_selection_strategy: prefer_conirmed, requires the --blocking flag, and requires pre account_fund ing a large number of addresses. Going forward, it would be good to be able to batch a list of transaction commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: wallet consider soon Discuss this issue at the next planning meeting, then remove this label priority: medium Work needs to be done within 2-3 sprints type: new feature New functionality that does not exist yet
Projects
None yet
Development

No branches or pull requests

4 participants