Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tapid / Tap Label not populating in web interface #30

Closed
austinpe opened this issue Jul 1, 2022 · 8 comments · Fixed by #39
Closed

Tapid / Tap Label not populating in web interface #30

austinpe opened this issue Jul 1, 2022 · 8 comments · Fixed by #39

Comments

@austinpe
Copy link

austinpe commented Jul 1, 2022

I just realized that the tap labels / tapid aren't populating in the web interface after update in the alpha[1.1.0-Alpha.3] release (tapio branch)

The actual update of the object works (confirmed via API):
image

But, the web interface doesn't seem to pull the data correctly:
image

image

@lbussy
Copy link
Owner

lbussy commented Jul 1, 2022

The taplist.io has fixes for that as far as I know. We use BrewFlasher to flash these so the code in the repo is not necessarily what's "released" right now. That's a poor excuse for being untidy but that's the reason.

@austinpe
Copy link
Author

austinpe commented Jul 1, 2022

I used the brewflasher desktop app, but I'll try the web one.
This was the taplist.io one, I thought.
But, I'll double check.

@thorrak
Copy link
Collaborator

thorrak commented Jul 1, 2022

I accept bribes to force Lee’s repo to always update BrewFlasher.

Just sayin’.

@lbussy
Copy link
Owner

lbussy commented Jul 1, 2022

Maaaaaybe I forgot to push. I'll do that in a few hours.

@austinpe
Copy link
Author

austinpe commented Jul 1, 2022

I just flashed and tested the one from the brewflasher webapp and it's the same issue 😄

@lbussy
Copy link
Owner

lbussy commented Jul 1, 2022

The 1.0.0? That's really weird because it's been working. I mean I know the issue (index.js calling for taplabel instead of label) but my kegerator works and was using that version.

Mysteries!

@austinpe
Copy link
Author

austinpe commented Jul 1, 2022

Not 1.0.0, but on 1.1.0-Alpha.3 (the one you linked in the other bug).

I confirmed using Chrome's inspector tool to look at index.js that indeed it's still 'taplabel' instead of label.
I cleared my cache and tried in incognito mode just in case it was somehow cached. But, nope, it's still there.

@lbussy
Copy link
Owner

lbussy commented Jul 1, 2022

fixed. Updated Keg Cop Alpha to 1.1.0-Alpha.4

@lbussy lbussy closed this as completed Jul 1, 2022
@lbussy lbussy linked a pull request Jul 7, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants