Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpha Update - Kegscreen POST Only Works on Port 80 #32

Closed
austinpe opened this issue Jul 2, 2022 · 5 comments · Fixed by #39
Closed

Alpha Update - Kegscreen POST Only Works on Port 80 #32

austinpe opened this issue Jul 2, 2022 · 5 comments · Fixed by #39

Comments

@austinpe
Copy link

austinpe commented Jul 2, 2022

I think the latest library update broke some functionality with the HTTP POST.

Previously, I was using the Keg Screen target functionality of Keg Cop to send reactive reports to an LCD screen.
I specified the port in the target field (e.g. http://keezer-lcd.local:8080 ) and it worked fine.
Since the latest update, after the library and platform update, the port specification seems to be ignored.

I can see requests come in only if I start a server on port 80 regardless of which port I set in the target field.
For example: if I start the server on port 80 then I see requests even if it say port 8080, 8334, 1337, etc in the keg screen target field -- this leads me to believe that the code is ignoring the port designation altogether now.

This may be outside of the scope of the intended use.
Is keg screen only foreseen to operate on port 80?

@lbussy
Copy link
Owner

lbussy commented Jul 3, 2022

I'm not sure I directly considered it, but there's no reason I can't add that.

@lbussy
Copy link
Owner

lbussy commented Jul 3, 2022

This is fixed in Alpha.5, along with some Taplist.IO stuff. Turned out to be a forgotten change in LCBUrl that broke this.

Updated Keg Cop Alpha to 1.1.0-Alpha.5

@lbussy lbussy closed this as completed Jul 3, 2022
@lbussy
Copy link
Owner

lbussy commented Jul 4, 2022

All of your current issues should be fixed in 1.1.0-Beta.2.1.

Updated Keg Cop Beta to 1.1.0-Beta.2.1

@thorrak is trying to talk me into re-doing the UI with Vue so .....

@austinpe
Copy link
Author

austinpe commented Jul 4, 2022

I obviously think that's a great idea 😉
And, I can help with it if you want!

@lbussy
Copy link
Owner

lbussy commented Jul 4, 2022

Well, I'm going to learn it and he's poking at reproducing the interface. After that, who knows!?

@lbussy lbussy linked a pull request Jul 7, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants