Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate settings from the old go #75

Closed
mark-crichton opened this issue Aug 26, 2023 · 4 comments · Fixed by lchsiteam/lchs-go-pwa#429
Closed

Migrate settings from the old go #75

mark-crichton opened this issue Aug 26, 2023 · 4 comments · Fixed by lchsiteam/lchs-go-pwa#429
Assignees

Comments

@mark-crichton
Copy link
Collaborator

To ease migration to the new go, we should detect if the user has settings from the old go and translate them into the new go's settings

@Apricitine
Copy link
Collaborator

gud, but how to do
localStorage isn't shared right? so we'd have to put the old go localStorage settings in a cookie and write an api route to give the cookie data to the new go

or maybe (in the old go) give the user an option to export their settings into a link for the new go (i think that's already a feature in the new go so this would be easier to implement)

@Apricitine Apricitine self-assigned this Aug 26, 2023
@aschmitigal22
Copy link
Collaborator

New go already has loading settings from a url generated by the "Share Settings" button on the settings page. If you add a button to the old go settings page that constructs a valid link from the settings then you could just link them to new go and it will load them all.

The share button on new go just JSON.stringify()'s the settings and creates the url with the parameters ?setSettings=<string here>&settings (&settings so that you show up on the settings page when the page loads). The code for this on Line 416 in vueScript.js

@awesomehaze
Copy link
Contributor

Good to close?

@Apricitine
Copy link
Collaborator

Apricitine commented Sep 7, 2023

yup :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants