Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffprobe uses buffer while checking frames #18

Closed
WoZ opened this issue Oct 3, 2018 · 2 comments
Closed

ffprobe uses buffer while checking frames #18

WoZ opened this issue Oct 3, 2018 · 2 comments
Labels
bug Something isn't working

Comments

@WoZ
Copy link
Member

WoZ commented Oct 3, 2018

So this issue gives incorrect values for the first analysis via method processFrame() (and future processFrames.encoderStats() and processFrames.networkStats()) methods.

@WoZ WoZ added the bug Something isn't working label Oct 3, 2018
@WoZ WoZ mentioned this issue Oct 3, 2018
@WoZ
Copy link
Member Author

WoZ commented Oct 3, 2018

Btw, PR I've added brokes functional tests. That's because previously FramesMonitor received a full set of audio and video frames from the beginning of a mp4 test file (ffmpeg -listen 1 waits for incoming connection to start stream the file). That buffer helped to calculate video and audio frames.

If we add -fflags nobuffer first frame received by monitor may vary from platform to platform and from version to version of ffmpeg/ffprobe.

I see few solutions:

  • remove failing functional tests
  • replace failing test files with new ones and rely deeply on some frame, let say, at 5 sec from the beginning of file.

The second approach will work only when ffmpeg/ffprobe can determine metadata of the stream prior detection of "control" frame. Additionally, -probesize may help to prevent overflow but I think that this is bad idea to tune -probesize. I saw a lot of segfaults with incorrect values and probesize may cause false negative results.

Guys, what do you think? @fox-hellraiser @OlegPoberegets

@fox-hellraiser
Copy link
Member

@WoZ

remove failing functional tests

ff

@WoZ WoZ closed this as completed in #19 Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants