Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Korean: Capitalization of test strings #30

Closed
scossu opened this issue Jul 21, 2023 · 2 comments
Closed

Korean: Capitalization of test strings #30

scossu opened this issue Jul 21, 2023 · 2 comments
Milestone

Comments

@scossu
Copy link
Collaborator

scossu commented Jul 21, 2023

In some of the test strings, the romanization start with a capital letter. In some others it doesn't.

If I run the tests without capitalizing the first word, most tests fail because the first word wouldn't be normally capitalized. If I capitalize the first word of all strings, the ones that don't start with a capital letter will fail.

I am not sure if the tests are failing with capitalization off because of an error in my code that is not capitalizing a word that should always be so, or because some test strings have been capitalized on the first word.

Examples of test strings not starting with a capital:

기술 경영 의 이해 -> kisul kyŏngyŏng ŭi ihae
기업 경영 국제 경영 부문 -> kiŏp kyŏngyŏng kukche kyŏngyŏng pumun
기업 경쟁력 강화 를 위한 내부 고발 과 윤리 경영 -> kiŏp kyŏngjaengnyŏk kanghwa rŭl wihan naebu kobal kwa yulli kyŏngyŏng

Strings starting with a capital:

기업 이 알아야 할 100가지 소프트웨어 저작권 상담 사례 -> Kiŏp i araya hal 100-kaji sop'ŭt'ŭweŏ chŏjakkwŏn sangdam sarye
기업법 개설 제 12판 -> Kiŏppŏp kaesŏl che 12-p'an
기초 연구 투자 의 경제적 파급 효과 분석 -> Kich'o yŏn'gu t'uja ŭi kyŏngjejŏk p'agŭp hyogwa punsŏk

@hyoungl is there a fixed rule here?

@scossu scossu changed the title Capitalization of test strings Korean: Capitalization of test strings Jul 21, 2023
@hyoungl
Copy link
Collaborator

hyoungl commented Jul 22, 2023

Capitalization was not really the part of the test, because K-romanizer has three different key combos in terms of capitalization. For Scriptshifter, it makes more sense to capitalize the first letter by default.

@scossu
Copy link
Collaborator Author

scossu commented Jul 22, 2023

Good to know. I will capitalize all the firsts then. Thanks.

@scossu scossu closed this as completed Jul 22, 2023
@scossu scossu added this to the Phase 2 milestone Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants