Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StrictValidAt Backwards Compatibility #722

Closed
Sephster opened this issue Apr 17, 2021 · 2 comments
Closed

StrictValidAt Backwards Compatibility #722

Sephster opened this issue Apr 17, 2021 · 2 comments

Comments

@Sephster
Copy link
Contributor

Sephster commented Apr 17, 2021 •
edited
Loading

Hey Luís,

ValidAt was deprecated in the 4.x branches in favour of the StrictValidAt constraint. The StrictValidAt constraint has not been backported to the 3.4x branch so is currently causing some of my tests to fail.

Would a PR be welcomed to backport this or are there no plans to do this? Many thanks for all the good work and awesome library as usual.

Andy
@lcobucci
Copy link
Owner

Hey Andy 👋

v3.x is open for security fixes only. So, we shouldn't backport anything else there.

If you want to use the new classes you should require v4.1+ (as they aren't available in v4.0.x).

If you need to be compatible with the old versions but still want to use the new classes, I'd suggest checking if the class is defined. Alternatively, you may also create the constraint on your side.

@Sephster
Copy link
Contributor Author

Sounds good to me. Thanks so much. Will take another look and sort it from our side. Thanks 👍

@Sephster Sephster mentioned this issue Jun 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lcobucci @Sephster