Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We should eventually use StableRNGs for sampling and all other random number generation. #84

Closed
exaexa opened this issue Apr 12, 2021 · 2 comments · Fixed by #466
Closed

We should eventually use StableRNGs for sampling and all other random number generation. #84

exaexa opened this issue Apr 12, 2021 · 2 comments · Fixed by #466
Assignees
@stelmo
Labels
quality improves maintainability and code clarity
Milestone
Release - v1.2

Comments

@exaexa
Copy link
Collaborator

exaexa commented Apr 12, 2021

Originally posted by @exaexa in #78 (comment)

Also see the related issue in GigaSOM:
LCSB-BioCore/GigaSOM.jl#147
@stelmo stelmo mentioned this issue Apr 12, 2021
Closed
@laurentheirendt laurentheirendt added this to the Release - v1.2 milestone Apr 16, 2021
@exaexa exaexa added the quality improves maintainability and code clarity label Apr 19, 2021
@stelmo
Copy link
Collaborator

stelmo commented Jun 5, 2021

@exaexa can I close this?

@exaexa
Copy link
Collaborator Author

exaexa commented Jun 5, 2021

nope, this is required for reproducibility.

exaexa added a commit that referenced this issue Oct 18, 2021
@exaexa
convert the sampling to stable RNGs
216dc7b 
Closes #84
@exaexa exaexa mentioned this issue Oct 18, 2021
Merged
exaexa added a commit that referenced this issue Oct 18, 2021
@exaexa
convert the sampling to stable RNGs
9188cb6 
Closes #84
exaexa added a commit that referenced this issue Oct 19, 2021
@exaexa
convert the sampling to stable RNGs
5972fff 
Closes #84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stelmo stelmo

Labels
quality improves maintainability and code clarity
Projects
None yet
Milestone
Release - v1.2
Development

Successfully merging a pull request may close this issue.

convert the sampling to stable RNGs LCSB-BioCore/COBREXA.jl
3 participants
@exaexa @stelmo @laurentheirendt