Merge pull request #2895 from kinke/diNamespaces

Add DI namespaces & use them for templates and C++ namespaces
ldc-developers · Nov 9, 2018 · 9537185 · 9537185
2 parents 7bcd6d3 + 71dfc4a
commit 9537185
Show file tree

Hide file tree

Showing 4 changed files with 450 additions and 321 deletions.
diff --git a/driver/linker-msvc.cpp b/driver/linker-msvc.cpp
@@ -114,7 +114,9 @@ int linkObjToBinaryMSVC(llvm::StringRef outputPath,
     args.push_back("/OPT:NOREF");
   } else {
     args.push_back("/OPT:REF");
-    args.push_back("/OPT:ICF");
+    // don't fold identical COMDATs (e.g., functions) if debuginfos are enabled,
+    // otherwise breakpoints may not be hit
+    args.push_back(global.params.symdebug ? "/OPT:NOICF" : "/OPT:ICF");
   }
 
   // add C runtime libs