CodeView: add support for imaginary and complex types #1730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| LLMetadata *elems[] = { | ||
| CreateMemberType(0, elemtype, file, "re", 0, PROTpublic), | ||
| CreateMemberType(0, elemtype, file, "im", t->alignsize(), PROTpublic)}; |
There was a problem hiding this comment.
I think there's a chance that t->alignsize() != getTypeAllocSize(T) for 80-bit real. So I'd suggest using getTypeAllocSize(T) here, like below.
There was a problem hiding this comment.
Thanks, changed that. alignsize was even called on the wrong type.
Also removed the failing assert left over from copy 'n paste.
|
Travis and CircleCI retriggered. |
|
Thanks, another one checked off the list at #1716 (but a different one added, too). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maps imaginary types to the floating point types, creates a struct for complex types.